Yelp/aactivator

`pipes` is deprecated

Closed this issue · 2 comments

The script currently has from pipes import quote. pipes is deprecated in python3.11, and will be removed in 3.13 (https://docs.python.org/3/library/pipes.html).

Would anyone mind if I made a PR to replace that import with from shlex import quote, since that's where pipes was getting that function from anyways (https://github.com/python/cpython/blob/3.11/Lib/pipes.py#L66)?

That would be great, thanks!

Will probably need to drop Python 2 support though, e.g. delete these lines:

aactivator/setup.py

Lines 17 to 18 in f74fac9

'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',

And add python_requires='>=3.7' to the same file.

...and I guess adjust the tests to stop testing Python 2.

If you just want to do a conditional import for now that would be OK, and then we can handle dropping Python 2 support separately later.