Add setup_requires or a requirements.txt to improve pip installs.
JoshuaC3 opened this issue · 2 comments
On occasions, when installing bravado into a directory using pip, the requirements are not installed to the directory. After some searching, I found this which hints a package would benefit from having these listed in the setup_requires as well as install_requires in the setup.py file. This SO question highlights that having setup_requires is useful when redistributing the package. This is the use case I have; I am trying to use bravado in an AWS Layer to work with AWS Lambda.
Alternatively, having a requirements.txt instead of listing deps in setup.py would also address this issue.
As was pointed out in a comment to the SO answer, setup_requires is for dependencies as install time while install_requires is for runtime dependencies. As the other SO answer pointed out, more likely than not the issue for the person asking the question was related to them providing a cmdclass argument.
Either way, this is not a bug in bravado - doing pip install bravado will install all required dependencies. Please either provide specific steps to reproduce, or file a bug with AWS Lambda if they do not honor requirements specified in setup.py.
Point taken. Thanks for clarifying.