Yelp/dumb-init

Tests with gcov are throwing: Version mismatch - expected A73* got 402*

edgar opened this issue · 2 comments

edgar commented

I cloned the repo and when I'm running make itest_tox, tests pass on python 2.7 and 3.6 but tests/cli_test and tests/tty_test.py are failing on gcov, the output looks like:

_____________________ test_rewrite_errors[0-0-extra_args9] _____________________

extra_args = ('-r', '15:12', '-r', '1:32')

    @pytest.mark.parametrize('extra_args', [
        ('-r',),
        ('-r', ''),
        ('-r', 'herp'),
        ('-r', 'herp:derp'),
        ('-r', '15'),
        ('-r', '15::12'),
        ('-r', '15:derp'),
        ('-r', '15:12', '-r'),
        ('-r', '15:12', '-r', '0'),
        ('-r', '15:12', '-r', '1:32'),
    ])
    @pytest.mark.usefixtures('both_debug_modes', 'both_setsid_modes')
    def test_rewrite_errors(extra_args):
        proc = Popen(
            ('dumb-init',) + extra_args + ('echo', 'oh,', 'hi'),
            stdout=PIPE, stderr=PIPE,
        )
        stdout, stderr = proc.communicate()
        assert proc.returncode == 1
>       assert stderr == (
            b'Usage: -r option takes <signum>:<signum>, where <signum> '
            b'is between 1 and 31.\n'
            b'This option can be specified multiple times.\n'
            b'Use --help for full usage.\n'
        )
E       AssertionError: assert b'Usage: -r o...3* got 402*\n' == b'Usage: -r op...full usage.\n'
E         Left contains more items, first extra item: 112
E         Full diff:
E         (b'Usage: -r option takes <signum>:<signum>, where <signum> is between 1 and 31'
E         b'.\nThis option can be specified multiple times.\nUse --help for full usage'
E         -  b'.\nprofiling:/test/dumb-init.gcda:Version mismatch - expected A73* got 40'
E         -  b'2*\n')
E         ?    ^^
E         +  b'.\n')
E         ?    ^

tests/cli_test.py:143: AssertionError

I checked and gcc and gcov in the container have the same version (v7.3.0)

Any suggestions?

@edgar is it possible you ran the gcov tests outside the container first? Maybe try git clean -fxfd && make itest_tox

edgar commented

@asottile thank you! that worked