Performance regression
stayallive opened this issue · 6 comments
What did you expect to happen?
Updating to Yoast SEO News 12.4 to not degrade performance.
What happened instead?
It did.
How can we reproduce this behavior?
Observe the changes in responsiveness. Potentially only on larger sites with many post types / tax combinations.
In our case get_terms is called +30k times every request compared to News 12.3:
Looking at the callgraph the source is the new options class:
I really hope my suggestion for the performance improvements is not the cause of all this
Technical info
- WordPress version: 5.3.2
- Yoast SEO version: 12.8 (SEO News 12.4)
Hi @stayallive and thanks for your report! We're already working on this as we've had multiple reports coming in. This PR should fix this and we're planning to release this tomorrow (tuesday at around midday UTC+1).
I can't link this issue to a PR fixed-trigger anymore since it was already merged. So to prevent it from staying open too long I'm going to close it now. But please keep an eye out and test the patch of tomorrow. If the problems are not mitigated I'd really like to know, so you can leave a comment here.
I didn’t even looked. Perfect! If it does not resolve it I’ll be back with more info. Thanks to everyone involved
Ah the reports were not via GitHub, so apart from the PR I don't think you could've known :) Better safe than sorry!
@stayallive 12.4.1 has been released, please let us know if you're still running into issues.
As far as we can tell it looks good
Cool, thanks for the report and feedback!