Yooooomi/your_spotify

[Feature Request] Return version without login

bloedboemmel opened this issue · 4 comments

bloedboemmel commented

Just a very small tweak, but it would help a lot monitoring my projects with Argus

Would it be possible to return the version, when using the GET /version from the API

your_spotify/apps/server/src/routes/index.ts

Line 194 in bba31e0

router.get("/version", logged, async (_, res) => {

Or do you consider it a security risk?

Yooooomi commented

Do you know any other project that allows fetching the version using GET for your monitoring? How do you do usually to connect these projects to your Argus thing?

bloedboemmel commented

Bitwarden gives you the version without a login at admin/home/getinstalledwebversion
and Audiobookshelf sends it in the html without login, you just need to regex it.

It would also help just to put it in the headers of the login html

Yooooomi commented

I'll definitely fix this next release then

  • ❤️1