Yubico/yubico-piv-tool

EC_GROUP_new_by_curve_name(nid) not freed after use

Closed this issue · 1 comments

bentonstark commented

yubico-piv-tool/tool/yubico-piv-tool.c

Line 272 in 9f545e7

group = EC_GROUP_new_by_curve_name(nid);

ref: https://www.openssl.org/docs/man1.1.0/man3/EC_GROUP_new_by_curve_name.html

EC_GROUP_free frees the memory associated with the EC_GROUP. If group is NULL nothing is done.

qpernil commented

This looks fine to me, there is a call to EC_GROUP_clear_free later in that function. I will close this issue now, please feel free to create a new issue if you believe I'm mistaken.

/Per