YunoHost-Apps/dokuwiki_ynh

Update for new versions

Jaxom99 opened this issue · 12 comments

Hello dear maintainer(s),

My wiki install screams that there are updates (49.3-4-5), refering to http://download.dokuwiki.org/ .
Hotfix release available: 2017-02-19e "Frusterick Manners". upgrade now! [49.5] (what's this?)

Do you have any time to publish an update to this package ?

Thanks a lot !

I tried via the "upgrade plugin" : some file permissions prevents me from doing so. I chown-ed the whole directory to dokuwiki:dokuwiki but the upgrade didn't complete.

And then I tried via the official way, which is to overwrite files with the new version : login was disabled, admin section disappeared, and anyone could edit the wiki. Hopefully I was able to reverse the overwritting from a previous backup.

My waiting solution to the warnings is : edit doku.php and change $update_version to the current number (50.1). It will hide the warnings...

If you can, could you try the testing version of Dokuwiki and give feedback ?

See here for details and instructions : https://forum.yunohost.org/t/official-app-dokuwiki/5366

So here is the steps I followed :

  • Install of the regular app on a different subdomain
    • No alert for update is shown on the website, although version is still "Frustering". (?!)
  • Adding the "upgrade" plugin via admin panel
    • says there is an upgrade (from Frustering to Greebo) but fails to do it (files not writable, same error as before)
  • switching to testing version via CLI sudo yunohost app upgrade dokuwiki__2 -u https://github.com/YunoHost-Apps/dokuwiki_ynh/tree/testing --debug
    • the last version (2018-*) is fetched from the dokuwiki website
  • the dokuwiki is then on "Greebo" version 👍 and the upgrade plugin says there's no upgrade.

➡️ All in all, the yunohost "testing" version works. However I don't get why I don't have the warnings on this install (whereas on the first dokuwiki app, if I remove my workaround, the warnings are displayed).

I hope it enlightens you in some way !
NB : I forgot to mention it before, I run raspbian jessie on a Pi3, and Ynh is v2.7.14

Thanks for the feedback. Glad to know it worked for you espacially on raspberry as I did not test on it.
I will report it on the forum so other people will get the feedback.

arrow_right All in all, the yunohost "testing" version works. However I don't get why I don't have the warnings on this install (whereas on the first dokuwiki app, if I remove my workaround, the warnings are displayed).

According to the page https://www.dokuwiki.org/update_check, updates are checked only once a day so I guess that you should wait one day to get the warning

OK, thanks for clarifying that. I stay available for any further inspection before the app' change !

Hello,

A new stable version has been released following the testing version you already tried. There have been other fixes in the meantime.

Feel free to try it

I did try, and the upgrade went well for the first instance of DW, but now it returns a 502. Nginx logs indicate "open() "/usr/share/nginx/htmlindex.php" failed (2: No such file or directory)".

It turns out that the php7.0-fpm service is dead, because my second instance of DW refused to upgrade, and was removed because of upgrade errors : it's not on the tile menu anymore, and the data was removed from /var/www 😞. (There is a backup though).
So there is an FPM pool unable to start because it looks for /var/www/dokuwiki__2, and php7 crashes.

Where should I report this upgrade bug ? In the log of the second upgrade, there is a line with a "//" in the path, maybe the bug comes from there :

2018-11-09 11:22:05,727: WARNING - File /etc/nginx/conf.d/calc.tchack.xyz.d/dokuwiki__2.conf has been manually modified since the installation or last upgrade. So it has been duplicated in /home/yunohost.conf/backup//etc/nginx/conf.d/calc.tchack.xyz.d/dokuwiki__2.conf.backup.20181109.112205

NB : I should precise that, after the previous posts, I upgraded YNH to last version (3.2.2) and Rasbian to stretch.

Thanks for your feedback.

Somebody had a similar issue while upgrading the wiki (See #43 and YunoHost/issues#1231)

To sum up, there was a problem on the server with Nginx that made the upgrade to fail. After upgrading, Yunohost removed the new version to restore the pre-upgrade version. But there was a bug in the Dokuwiki restore script and it did not backup the data properly in the first place... So you end up with your data being purged.

About your issue, I believe that you could get more answers by posting of the Yunohost forum as on Github, you will reach fewer people : some applications maintainers and Yunohost people.

Could you post the following logs :

  • full log file of the upgrade
  • nginx
  • php

Feel free to ask if you need help to locate theses files

Thanks for your help :)
Here are the logs of ynh operations :

Is this everything you need ?

It looks good, thanks. Had a quick look at upgrade of DW second instance and can confirm that the backup script has the same bug : it does not backup data. Too bad for a backup script ...

Did not search for the reason of the upgrade failure as I cannot have a look right now. I should be able to have a look next week.

With all these logs, you could post on the forum to get an answer more quickly.

Okay thanks, I will post in the YNH forum ASAP.