YunoHost-Apps/synapse_ynh

[suggestion] Disable database backup when doing an upgrade

Ezwen opened this issue · 4 comments

Ezwen commented

Each time I upgrade synapse on Yunohost, it takes a huge amount of time because of the database backup it makes just before the upgrade attempt.

However, as far as I know, upgrading synapse never alters the database, it only alters configuration files and synapse installation itself, right?

Therefore, I would suggest to find a way to disable entirely the database backup during the pre-upgrade backup, if that possible.

I understand your point of view but I had many problem with the upgrade of some user how as broken his instance, so it's the reason because I had implemented the backup before the upgrade.

I propose to make app setting that you can set to disable the backup. But after if the upgrade fail and the app is broken it will be at your own risk.

Ezwen commented

An option would be OK for me :)

I have pushed a release witch implement this, so I close the issue if it's ok for you.
The settings to set for that is written in the readme.

Ezwen commented

that's really nice of you, thanks! I'll give it a try!