YusukeIwaki/puppeteer-ruby

Setting timeout: 0 in wait_for_function should disable the timeout

Closed this issue · 3 comments

Step To Reproduce / Observed behavior

page.wait_for_function('() => document.querySelector("body").innerText.includes("Something")', timeout: 0)

Expected behavior

wait_for_function should continue waiting without limit.
Currently it waits for 0ms.

Environment

ruby 3.0.2p107

This was also reported and fixed in the JS version of Puppeteer here: puppeteer/puppeteer#1920

Hi, thank you for the king bug reporting. I will fix it soon.

puppeteer-ruby 0.37.2 would fix this issue.
Thank you.

That was quick. Thanks!