Yvand/EntraCP

Nightly Release

Closed this issue · 15 comments

julmsy commented

Hello @Yvand,

I took some time today to test the Nightly release, but it seems that you provided a new version yesterday (20230419).
However this version seems to be... a step back?
There is no more option to add the extension attribute value in the tenant form to register:
image

Tested the WSP and also the source code that I compiled.
Could you please have a check ?

Thanks!

Yvand commented

hello @julmsy , it is unexpected, I'll check this and keep you posted

Yvand commented

@julmsy it is fixed, it was a dumb issue in my workflow

julmsy commented

@Yvand ok thanks, will test it!

julmsy commented

Ok, maybe I missed something but:

  • The AzureCP.wsp file from Nightly release 20230420 is OK. I have the extension attributes entry.
  • However, if I take the source code, compiled it, and then update the solution, the extension attributes entry disappears. I repeated the scenario twice just in case...

Also, could you please tell me where I can set the version easily when you compile the source code?
I've found this, but I guess there is a better way:
image
image

I'm still learning VS :)

Yvand commented

This is probably because you compile the master branch, which contains the latest published version.
All the changes not yet published are on dev branch, you should compile that one.
To set the version, you need to set the property AssemblyFileVersion in file AssemblyInfo.cs.

julmsy commented

Well, I took this one, so I expected to be the source code of the Nightly release:
image

Is it not correct?

Yvand commented

Hmm yes it should, but I just checked and, indeed, it's not the expected version.
There is something wrong in my workflow, I think I understand what it is, I'll fix it next week and update this thread

julmsy commented

😄
Ok good, enjoy your week-end!

Yvand commented

@julmsy I just fixed it, now all the assets, including the source code, are created using the expected commit

julmsy commented

Hello @Yvand
Many thanks! I'll time some time this week to test it.

  • 👍1
julmsy commented

Ok, seems to be really better regarding the source code 😄

Here are my few little remarks. I insist that they are non-blocking points, and do not interfere with the proper functioning of AzureCP.

  • Just for info, there are two removed references of .snk:
    image

  • From Central Administration, there is a duplicate column 'Display name':
    image

  • If I'm looking for an extension attribute, there are still a user reference. It could be a bit confusing in some situation.
    For the example below, this BrandCode extensionattribute is the same for hundred/thousand of peoples behind. So there is no really reason that identity of someone appears here (same thing from Central Admin).
    But in other side, an extensionattribute could be an unique value (like an employee ID), and in this case, that could make sense to display the identity of the user.
    image

Other than these remarks, all good!
Let me know if you would like to open a issue for one of these points, I'll do it.

Yvand commented

@julmsy regarding the extension attribute which shows a user value in the people picker, you can use the solution I mentioned in #174 (comment) to avoid it

julmsy commented

@Yvand ah yes very good point, I completely forgot this configuration.
So yes, all good with this solution.
Thanks to remind me this!

  • 👍1
Yvand commented

And regarding the duplicated column 'Display name', it's a good point, actually I never noticed it.
But there is probably not much to do: AzureCP returns the 'Display name' just as it should, it's just too bad SharePoint duplicates it

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.