Extraction of archive not completed, in some cases, when integrating with fs.createReadStream.pipe()

[nlisgo]

await fs.createReadStream('/path/to/source.zip')
  .pipe(unzipper.Extract({ path: '/path/to/destination' }))
  .promise();

We found the above approach sometimes resulted in not all files in the archive been extracted and with no error thrown. We resolved by refactoring and dropping the use of fs

await unzipper.Open.file(mecaPath)
  .then((dir) => dir.extract({
    path: tmpDirectory,
  }));

See: elifesciences/enhanced-preprints-import@7dcac0c

I'm prepared to provide more information and perhaps some example code demonstrating different outcomes for both. I'm posting here, not because I'm certain this is a bug but in case it is and I want to support the project in helping to fix it.

I also thought it may be useful for others who may have experienced the same issue to see how it can be resolved.

[farz4n3hhl]

Hi @nlisgo

I had the same issue in my project!

After struggling a lot, upgrading the package to the latest version (unzipper@0.12.3) seems to have fixed the problem.

[bladerunner2020]

I have the same issue with 0.12.3 – out of three directories, only one is unzipped.