Dmg Calculation does not cap CDmg at 350%
Opened this issue · 2 comments
Dmg Calculation does not cap CDmg at 350%. As a result, when searching for high Dmg builds, you can come across builds that have lower Atk but have higher CDmg than other builds that actually do more damage.
Using my C!Lorina as an example:
My top listed Dmg build has 3930 atk and 361% CDmg. 3930 x 3.61 = 14,187.3
The optimizer lists that build's Dmg value as 14188. That being said, ingame the CDmg is capped at 350%; extra CDmg doesn't add to the damage.
This error also carries over to Dmg/Spd calculations.
Luckily, I don't think the Crit Rate has the same problem.
You just have to add a clause in the calculations that rounds any CDmg value above 350% down to 350%.
On a minor note, the calculations in general appear to have a rounding error (they round up when they should round down, see the number example above). They're quite minor, only resulting in stat differences of about ~2, but they're annoying to see.
C!Lorina differences: missing 17 atk, 2% CDmg and 2% DAC. All presumably from her Skill tree.
The other SC units probably also need a check to make sure their values are up to date after +30'd skill trees.