Zelaf/uptime-kuma-service-push

Consider reducing dependencies

Closed this issue · 2 comments

I believe that these can be removed, as they are available everywhere no?

  • tail
  • cat
  • echo
  • printf
  • mkdir

dependencies:
- curl
- tail
- systemctl
- journalctl
- cat
- readlink
- echo
- printf
- mkdir

Zelaf commented

Figured why not have them just in case since they're used by Bashly and some libraries as well as my implementations. No harm really, question would be if the saves in removing redundancy is worth it.

I tried to look into what's most available for different Linux systems but in the end I'm still mainly configuring this for debian-like systems. So would probably be best to remove it anyway in terms of having the bashly.yml shorter.

What I've found so far is that echo's -e implementation is a bit non-standard so I've tried to use printf as much as possible while taking inspiration from the Bashly generated script. mkdir I have very rarely encountered not existing but that's mostly in docker systems or non-standard embedded Linux installations.

But for the sake of easier bashly.yml I think I will.

Zelaf commented

Changed with afd5c98