Rendering image tags

Question

Rendering image tags

rizwan95 opened this issue 2 years ago · 9 comments

Hello @zhgchgli0718
First of all thanks for making this wonderful framework. The framework works great with almost all html tags.
My question is what about Image tags?
Image tags are the most widely used in HTML.

Answer 1 · 2023-02-27T09:05:13.000Z

Hi, thanks for using ZMarkupParser

We are currently considering and researching the possibility of supporting <img> rendering. Rendering images requires an asynchronous job to download the image data, and displaying the image data directly using NSTextAttachment may cause out-of-memory issues. This is because the native NSTextAttachment does not support reuse, so all image data will be kept in memory. We need to conduct further research on TextKit or rely on third-party libraries like XLYTextKitExtension to find the best solution.

Answer 2 · 2023-02-27T09:07:40.000Z

Thanks for the reply @zhgchgli0718
You are right. NSTextAttachment is not efficient when rendering images.
I have been researching this problem for a while. I would love to share my knowledge and help you find a solution.

Answer 3 · 2023-02-28T03:14:14.000Z

Hi, it's actually very convenient to extend ZMarkupParser. I'll make ZMarkupParser support rendering <img> tags first, and add a delegate, such as a resource downloader, to let users handle image URLs and convert them to data.

I'm considering creating a new method using Combine to allow users to retrieve the downloaded image NSAttachment asynchronously.

It'll be released first, we will handle the NSAttachment out-of-memory problem later.

next stage,
If you could provide some assistance with NSAttachment out-of-memory problem, it would be very helpful!

Answer 4 · 2023-02-28T06:27:01.000Z

Hi,
That's a wonderful news!
Okay I can help you out with NSAttachment out-of-memory issue.

Answer 5 · 2023-02-28T09:16:12.000Z

Also, instead of Combine, you can also use AsyncStream if you want :)

Answer 6 · 2023-03-01T13:13:25.000Z

thanks for your information! @rizwan95

Answer 7 · 2023-03-05T16:35:18.000Z

Hi, @rizwan95
I've created a new module called ZNSTextAttachment, which can handle the operation of downloading images from remote URLs. This module can be used to implement any image-loading optimization ideas we may have.

and I have already created branch #7 that supports rendering the tag. Please feel free to review it and leave any comments if you have any questions or concerns.

Answer 8 · 2023-03-05T17:36:38.000Z

@zhgchgli0718 Amazing work! I will look into the possibilities to improve the loading time.

Answer 9 · 2023-03-09T15:40:35.000Z

resolved in 1.3.0