theater.play() and theater.stop() issue

Question

theater.play() and theater.stop() issue

AmineI opened this issue 9 years ago · 6 comments

Hello again ! I've been playing a lot with your awesome javascript, and i found an issue in one of the core features.
When you assign the theater.play() and theater.stop() toggles on a button, pressing it multiple times button within a certain amount of time (before the current scene/event stops) make Theater completely buggy, a fiddle will explain it better than me :

https://jsfiddle.net/AmineIzumi/yexw3do1/3/

(I also found a workaround, which is simply binding the toggle to the typing:end event)

Answer 1 · 2016-03-09T23:28:17.000Z

Thanks for the heads-up! That's definitely a bug so I'll have a look ;)

Answer 2 · 2016-03-13T11:16:54.000Z

So I figured out the issue and it's now fixed per 10d4152 ;)

Answer 3 · 2016-03-13T14:05:45.000Z

Thanks ! The fact that the fix is working locally but not in the fiddle (which use the CDN version) tells me that the CDN isn't up to date, or that the 2.0.2 isn't the 'latest' release for the CDN (which appears to be the case in the release tab of Github). Could you update the CDN to 2.0.2 as well :) ?

Edit : The CDN isn't considering the 2.0.2 as the 'latest' release, like i suggested. A workaround is to use the url //cdn.jsdelivr.net/theaterjs/2.0.2/theater.min.js instead of //cdn.jsdelivr.net/theaterjs/latest/theater.min.js

Answer 4 · 2016-03-13T21:28:39.000Z

Thanks for looking into it, /latest is probably cached on your side. Emptying it should make the latest version appear (it worked for me and /latest is 2.0.2). Let me know if it's still not working ;)

Answer 5 · 2016-03-13T21:33:26.000Z

You're right, i didn't thought about that :o ! However, what about Github Releases showing 2.0.1 as "latest release" ?

Answer 6 · 2016-03-13T21:43:50.000Z

Oh that's weird, I've added the v2.0.2 git tag but didn't use GitHub's ui to release it, that's probably why. I'll go through GitHub's documentation to learn more about that.