ZhukV/AppleApnPush

PHP 8 Support

sicaboy opened this issue · 10 comments

PHP 8 Support
ZhukV commented

@sicaboy thank for issue. I add support PHP 8 in #68 Pull request (Branch: feature/add-support-php8). Please install in your project and test. If all OK work, I merge PR and add new tag.

You can have problem in use JWT libraries, because I update them from ~1.0 to ~2.0 for development.

Thank.

P.S. For install in your project, you can add to you composer.json:

{
    "require": {
        "apple/apn-push": "dev-feature/add-support-php8"
    }
}
ZhukV commented

@sicaboy , Can you test #68 ?

ZhukV commented

@sicaboy , Can you test #68, or can I close this issue?

Sorry. I'll have a test ASAP

ZhukV commented

@sicaboy , thank, please reply after testing.

Thanks, @ZhukV I've tested the branch dev-feature/add-support-php8 with PHP 8.0.2. Closing this ticket.

ZhukV commented

@sicaboy , all correct work?

Confirming under required thru composer 2.0 with Laravel 8.5, all php unit cases passed in PHP 8.0.5

ZhukV commented

Thank. You try use certificate and jwt token authenticators?

@ZhukV First of all, thank you for your job!
I tested both certificate and JWT on PHP 8.0.3 + Symfony 5.2.6
Everything looks ok for me