ZivaVatra/flac2all

script bombs if opusenc isn't installed

GoogleCodeExporter opened this issue · 3 comments

What steps will reproduce the problem?
1. run flac2all without opusenc 
2.
3.

What is the expected output? What do you see instead?

% flac2all mp3 -l V4 "/mp3/blues/bb_king/B.B. King - Live At The Regal (1965) 
[SACD] (2011 SHM-SACD PCM Stereo)"

Flac2all python script, v3 . Copyright 2006-2015 Ziva-Vatra.com.
Licensed under the GPLv3 .
Project website: http://code.google.com/p/flac2all/


Traceback (most recent call last):
  File "/data/home/danno/bin/flac2all", line 811, in <module>
    opusClass = opus()
  File "/data/home/danno/bin/flac2all", line 99, in __init__
    data = re.search("\d\.\d\.\d",data).group(0)
AttributeError: 'NoneType' object has no attribute 'group'


What version of the product are you using? On what operating system?

downloaded august 1 2015.  running on centos6. 

Please provide any additional information below.

I tried faking it with a one-liner shell script so opusenc would at least exist 
- no luck, same crash.  

Everything works fine once I comment out all the "opus" stuff in the script.   

thanks for making this available.  keeping up with all the metadata options was 
a pain in the ass.

Original issue reported on code.google.com by danpri...@gmail.com on 1 Aug 2015 at 6:43

Indeed it does bomb. bug confirmed. 

Original comment by i...@ziva-vatra.com on 2 Aug 2015 at 4:16

  • Changed state: Accepted
Try revision 83 in svn. It should have fixed this issue. Let me know if it 
works for you. 

Original comment by i...@ziva-vatra.com on 2 Aug 2015 at 4:38

  • Changed state: Fixed
Correction, I ran tests today and found the fix lacking. Try revision 84 
instead. 

Original comment by i...@ziva-vatra.com on 4 Aug 2015 at 6:32