ZopaPublic/react-components

Navigation fails Lighthouse accessibility checks

Closed this issue · 5 comments

endymion1818 commented

We've added things like role="menu" and role="menuitem", but we are advised against doing this by accessibility experts: https://inclusive-components.design/menus-menu-buttons/

  • 👍1
endymion1818 commented

Also the whole header has the role="banner" where it should only be the logo container: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Banner_Role

  • 👍1
poteirard commented

Great findings both!
Does anyone of you want to get assigned to this issue? Or maybe @emilfjellstrom?
Else we can add the label help wanted in the issue.

endymion1818 commented

@poteirard I've started a PR, so happy to be assigned 👍

  • 🎉1
  • ❤️1
poteirard commented

🎉 This issue has been resolved in version 4.35.1 🎉

The release is available on:

Your semantic-release bot 📦🚀