ZupIT/beagle

[Android] Danger Validation for external contributors

Closed this issue · 2 comments

Please provide all the information requested. Issues that do not follow this format are likely to stall.

Description

The validation 'danger' added to the repository breaks when it runs against external forks of the repository.
The main message is: Commit x does not exist. Are you running 'danger' against the correct repository?

Steps To Reproduce

Provide a detailed list of steps that reproduce the issue.

  1. Fork the Android repository
  2. Try to open a pull request
  3. The validation should fail for 'danger'

Expected Results

External contributors should be able to run all the pull requests against all the required validation. Validation which are not essential should be skipped but no error should be raised.

Code example, screenshot, or link to a repository:

Pasted Graphic

👋 @hectorcustodiozup
Thank you for raising an issue. We will investigate into the matter and get back to you as soon as possible.
Please make sure you have given us as much context as possible and that you have followed our contributing guidelines.
We will review it as soon as possible.

Fixed at: https://github.com/ZupIT/beagle-android/pull/81/files. The problem was the depth of the checkout action.