Zwyk/ClassicCraft

Some Questions

Closed this issue · 4 comments

  1. Flurry accelerates attack speed by 30% according to the game, but not 1.1?
  2. How to add Crusader to weapons?

after all, thx to your good job.

Zwyk commented

Hello,

  1. Flurry does indeed add 30% attack speed with 5 points in it. The formula in the code is Haste = 1 + 0.1 + ((points - 1) * 0.05); = 1.3 = 30% more, at 5 points
    If you're getting a 10% increase in your logs, double check your talents string that Flurry has 5 points in it (but you probably have 0 and the 10% is a bug then, that I will fix).

  2. To add Crusader to your weapons, add an "Enchantment" with "Crusader" as "Name" in the Weapon json :
    "Enchantment": { "Name": "Crusader" }
    All Rogue and Warrior json examples all have Crusader on their weapons, you can copy/paste from there.

Thank you for your quick reply.
I can add Crusader now.
And I add 5 points to Flurry of my talent of wowhead, this time it is 1.3 😄 .

Two more questions(I'm sorry if these will take up too much of your time)

  1. Heroic Strike seems not appear in the logs
    has it been added to this tool?
    if added, how to use it?
    ( Heroic Strike is an important skill to Warrior as when the MH light it, the OF must hit)
  2. If MH and OF just cast normal attack,how can MH's Miss be 18.41%, but OF's be 3.94% ,I'm sorry but it seems unbelivable.
    I run several times but it keeps tell the rate
    please read my player.json & log

Here's the player.json(I do not edit some Equipments' and Enchantments' name but their Stats truly exist 😄 )

{
  "Race": "Human",
  "Class": "Warrior",
  "Talents": "30305001302-05050005525010051",
  "Cooldowns": {
  },
  "Buffs": [
    {
      "Name": "Test",
      "Stats": {
        "Hit": 0,
        "Crit": 0,
        "AP": 0,
        "Haste": 0,
      }
    },
    {
      "Name": "Devilsaur Set",
      "Stats" : {
        "Hit": 2,
      }
    },
    {
      "Name": "Leader of the Pack",
      "Stats": {
        "Crit": 3
      }
    },
    {
      "Name": "Battle Shout",
      "Stats": {
        "AP": 241
      }
    },
    {
      "Name": "Trueshot Aura",
      "Stats": {
        "AP": 100
      }
    },
    {
      "Name": "Mark of the Wild",
      "Stats": {
        "Agi": 16,
        "Str": 16,
      }
    },
    {
      "Name": "Elixir of Giants",
      "Stats": {
        "Str": 25,
      }
    },
    {
      "Name": "R.O.I.D.S.",
      "Stats": {
        "Str": 25,
      }
    },
    {
      "Name": "Elixir of the Mongoose",
      "Stats": {
        "Agi": 25,
        "Crit": 2
      }
    },
    {
      "Name": "Juju Power",
      "Stats": {
        "AP": 40,
      }
    },
    {
      "Name": "Juju Might",
      "Stats": {
        "Str": 30,
      }
    },
  ],
  "Weapons": {
    "MH": {
      "DamageMin": 59,
      "DamageMax": 110,
      "Speed": 1.7,
      "TwoHanded": false,
      "Type": "Sword",
      "Name": "Warblade of the Hakkari",
      "Id": 0,
      "Slot": "Weapon",
      "Stats": {
        "AP": 28,
        "Crit": 1,
      },
      "Enchantment": {
        "Name": "Crusader"
      },
    },
    "OH": {
      "DamageMin": 57,
      "DamageMax": 106,
      "Speed": 1.7,
      "TwoHanded": false,
      "Type": "Sword",
      "Name": "Warblade of the Hakkari",
      "Id": 0,
      "Slot": "Weapon",
      "Stats": {
        "AP": 40,
        "Sword": 6,
      },
      "Enchantment": {
        "Name": "Crusader"
      },
    }
  },
  "Equipment": {
    "Head": {
      "Name": "Lionheart Helm",
      "Stats": {
        "Str": 18,
        "Crit":2,
        "Hit": 2
      },
      "Enchantment": {
        "Name": "Lesser Arcane Amalgamation",
        "Stats": {
          "Haste": 1
        }
      }
    },
    "Neck": {
      "Name": "Onyxia Tooth Pendant",
      "Stats": {
        "Agi": 12,
        "Crit": 1,
        "Hit": 1,
      }
    },
    "Shoulders": {
      "Name": "Black Shoulders",
      "Stats": {
        "AP": 40,
      },
    },
    "Back": {
      "Name": "Cape of the Black Baron",
      "Stats": {
        "Agi": 15,
        "AP": 20
      },
      "Enchantment": {
        "Name": "Lesser Agility",
        "Stats": {
          "Agi": 3
        }
      }
    },
    "Chest": {
      "Name": "black",
      "Stats": {
        "AP": 50,
        "Crit": 2,
        "Hit": 1
      },
      "Enchantment": {
        "Name": "Greater Stats",
        "Stats": {
          "Str": 4,
          "Agi": 4,
          "Int": 4,
          "Spi": 4,
        }
      }
    },
    "Wrist": {
      "Name": "MC wrist",
      "Stats": {
        "Str": 24,
        "Agi": 8,
      },
      "Enchantment": {
        "Name": "Greater Strength",
        "Stats": {
          "AP": 7
        }
      }
    },
    "Hands": {
      "Name": "Devilsaur Gauntlets",
      "Stats": {
        "AP": 28,
        "Crit": 1,
      },
      "Enchantment": {
        "Name": "Haste",
        "Stats": {
          "Haste": 1
        }
      }
    },
    "Waist": {
      "Name": "MC Belt",
      "Stats": {
        "Str": 31,
        "Agi": 11,
        "Crit": 1,
        "Hit": 1,
      }
    },
    "Legs": {
      "Name": "Devilsaur Leggings",
      "Stats": {
        "AP": 46,
        "Crit": 1
      },
      "Enchantment": {
        "Name": "HASTE",
        "Stats": {
          "Haste": 1
        }
      }
    },
    "Feet": {
      "Name": "BLACK feet",
      "Stats": {
        "AP": 29,
      },
    },
    "Ring1": {
      "Name": "Tarnished Elven Ring",
      "Stats": {
        "Agi": 15,
        "Hit": 1
      }
    },
    "Ring2": {
      "Name": "Don Julio's Band",
      "Stats": {
        "AP": 16,
        "Hit": 1,
        "Crit": 1,
      }
    },
    "Trinket1": {
      "Name": "dragon",
      "Stats": {
        "AP": 56,
        "Hit": 2,
      }
    },
    "Trinket2": {
      "Name": "black hand",
      "Stats": {
        "Crit": 2,
      }
    },
  }
}

Here's the log

Average DPS : 585.09 dps (±0.00)

Average stats for [AA MH] : 181.47 DPS (31.02%)
	Average of 270.85 damage for 201.00 uses (or 1 use every 1.49s)
	6.97% Hit, 34.83% Crit, 18.41% Miss, 33.83% Glancing, 5.97% Dodge

Average stats for [AA OH] : 128.94 DPS (22.04%)
	Average of 190.56 damage for 203.00 uses (or 1 use every 1.48s)
	46.31% Hit, 32.02% Crit, 3.94% Miss, 14.29% Glancing, 3.45% Dodge

Average stats for [Bloodthirst] : 105.11 DPS (17.97%)
	Average of 808.56 damage for 39.00 uses (or 1 use every 7.69s)
	58.97% Hit, 28.21% Crit, 0.00% Miss, 0.00% Glancing, 12.82% Dodge

Average stats for [Whirlwind] : 32.89 DPS (5.62%)
	Average of 519.26 damage for 19.00 uses (or 1 use every 15.79s)
	47.37% Hit, 47.37% Crit, 0.00% Miss, 0.00% Glancing, 5.26% Dodge

Average stats for [Execute] : 64.17 DPS (10.97%)
	Average of 802.08 damage for 24.00 uses (or 1 use every 12.50s)
	87.50% Hit, 8.33% Crit, 0.00% Miss, 0.00% Glancing, 4.17% Dodge

Average stats for [Hamstring] : 9.41 DPS (1.61%)
	Average of 56.46 damage for 50.00 uses (or 1 use every 6.00s)
	62.00% Hit, 32.00% Crit, 0.00% Miss, 0.00% Glancing, 6.00% Dodge

Average stats for [Deep Wounds] : 11.25 DPS (1.92%)
	Average of 37.50 damage for 90.00 ticks (or 1 tick every 3.33s)
	90.00% Uptime
Zwyk commented
  1. It is used in the rotation, but I don't know why it doesn't appear in your logs, I'll check that. Adding all the % shows ~10% missing, probably from Heroic Strike (it usually is around 8-10%), try logfight : true to see the details of a fight and if Heroic Strike is used.
  2. Heroic Strike makes the OH act like a Special (Yellow) Attack in its Attack Table while HS is toggled, so it tends to have an overall better hit.