Zylann/godot_heightmap_plugin

How can I get rid of the 'metallic glow'?

NoTitleGamesOfficial opened this issue · 9 comments

my terrain looks like this:

Bildschirmfoto von 2023-10-15 16-59-09

I would like to disable the 'metallic glow' (I'm not sure what its called exactly) like I can do by setting the 'metallic' value on a spatial material to 0, as I did with this cube:
Bildschirmfoto von 2023-10-15 16-59-34
Bildschirmfoto von 2023-10-15 16-59-41

I hope you know what I mean. Sorry english isn't my native language so its a bit hard for me to describe it :)

Zylann commented

The shader in this plugin does not assign metallic... not sure why you get this difference. I assumed metallic defaulted to 0 in this case.
Which shader are you using?

If you want to choose metallic, you have to edit the end of the shader you are using. But look:

image

If I set METALLIC to 0, the result is the same:
image

If I set it to 1, it barely changes either:
image

If I force roughness to be 0.0 instead it gets like this:
image
But that's obviously not what you want as there are still highlights because surface is, well, "not rough".

However you could try to change SPECULAR instead, which apparently defaults to 0.5 otherwise:
image

I'm using Classic4Lite.

Your last image is the result I would like to have. Do you have some instructions how to get that, I never edited something with Shaders before.

Zylann commented

In the inspector, create a New Shader in the Custom Shader property:
image
This will create a copy of the builtin shader you had selected before.

Then switch Shader Type to Custom so it will start using the custom copy.

Then click on the Shader property value:
image

This will open the shader editor, in which you can add the line at the bottom:
image

I get this error when I add a custom copy:

Bildschirmfoto von 2023-10-15 21-58-46

Zylann commented

That was fixed in the master branch of the plugin. Just write the full path:

#include "res://addons/zylann.hterrain/shaders/include/heightmap.gdshaderinc"

So i got rid of the error, but nothing happens when adding the line? Do I need to somehow reload the terrain?

Zylann commented

No, it should just update immediately. Did you set Shader Type to CUSTOM in the inspector?

Zylann commented

I exposed specular in built-in shaders in afb412d

No, it should just update immediately. Did you set Shader Type to CUSTOM in the inspector?

... that did the trick :D
Thank you so much for your help and the great plugin. I'm currently poor but I'll spent you a coffee in the future ;)