a16z/magi

Error handling / HeadInfo

mishanefedov opened this issue · 1 comments

mishanefedov commented

Source: HeadInfo in /backend/types.rs

  1. The "try_from" implementation is returning "eyre::Report" instead of "Result", which can make debugging more difficult.
  2. The "From for sled::IVec>" implementation is using "panic!" in case serialization fails, which is not a good error handling strategy.
ncitron commented

closed by #122