a7ex/xcresultparser

Why need to get the dtd file by visiting http://cobertura.sourceforge.net ?

Closed this issue · 2 comments

kieoo commented

If the cobertura.sourceforge.net server is down, the tool will fatalError
Why not back up a local dtd file to avoid this problem ? @fadookie

xcresultparser/Sources/xcresultparser/CoberturaCoverageConverter.swift

Line 46 in 205604b

let dtdUrl = URL(string: "http://cobertura.sourceforge.net/xml/coverage-04.dtd"),

fadookie commented

This is working fine for me and seems to be a common practice when referencing a DTD. You are welcome to make a PR to use a cached copy of the DTD if you want.

a7ex commented

I made 1.4.2 with this change. Just because I tend to avoid fatalError()

  • 👍1