Dist minified version does not work in ie8
leebailey88 opened this issue · 5 comments
No offense, but I can't believe a package designed specifically to make old browsers work breaks with error in those exact browsers it is trying to help! See attached image.
The problem is that in ie versions below 9, you can't use reserved words such as catch, delete, class, etc. as identifier names in dot notation.
See this for full explanation: http://tiffanybbrown.com/2013/09/10/expected-identifier-bug-in-internet-explorer-8/
The frustrating thing is that you have your bower.json file set up to only include your dist folder and ignore everything else. This makes your package unusable to anyone who installs it with Bower.
@leebailey88
You might be right. I t makes sense to also copy the unminified files from the src to the dist folder. About your error. I can not reproduce this error. Could you give me a testcase? Which exact reserved word is used and where?
All I did was use the angular-fullstack Yeoman generator, and opened up the app in ie8 on a virtualbox windows 7 on my Macbook. The generator already includes your minified version in the index.html file. I'm not sure on the specific reserved words, but I assume that is the problem, because there are actually 10 or so other reserved word errors in the generated code that give the exact same "expected identifier". I fixed those manually by using ["identifier"] syntax rather than dot notation. When I manually used the unminified version of your library, it worked perfectly. It's possible the issue is something else I suppose, but it is definitely not happening on ie9 or any modern browser. Great library.
Sounds like an issue with minification somewhere in your build.
+1 for including unminified files in dist
Actually, I couldn't see/find any reserved word as an identifier. I switched know to grunt/uglify. While I'm now also copying the unminified version, it would be great to check, wether you guys have still problems with the *.min.js version.
Thanks. Please re-open, if error still occurs.
Sorry for not specifying—I was never able to replicate the issues that @leebailey88 was having, however having the unminified version in dist is useful for my custom grunt builds. Thank you for adding. Your work on this is much appreciated.