Ktor 2.0 support

Question

Ktor 2.0 support

joreilly opened this issue 3 years ago · 10 comments

I realise Ktor 2.0 is still in eap right now but just curious if there's know changes needed/planned to support it? I tried to update a project I have here to use Ktor 2.0 (using v0.17.14 of the library) but getting following

Type mismatch.
Required:
RouteScopedPlugin<TypeVariable(B), TypeVariable(F)>
Found:
GraphQL.Feature

Answer 1 · 2022-01-01T14:10:19.000Z

Just fyi that Ktor 2.0 is beta now so likely will see more projects starting to use it.

Answer 2 · 2022-01-17T15:26:43.000Z

Need to change types, would like to undertake this change.

Answer 3 · 2022-01-17T16:46:55.000Z

it makes me pretty worried because @jeggy seems not to be around to address this change

Answer 4 · 2022-01-18T02:15:50.000Z

@NathanPB check again, @jeggy is still active I guess.

Answer 5 · 2022-01-18T16:14:07.000Z

Created #179. It should add support for Ktor 2.0

Answer 6 · 2022-01-18T17:15:09.000Z

@NathanPB check again, @jeggy is still active I guess.

Yes, I was getting worried because he used to be very active here and suddenly disappeared

Answer 7 · 2022-02-24T15:13:40.000Z

is this still active?

Answer 8 · 2022-04-17T14:05:44.000Z

Hey People,

If you are looking to support this library with Ktor 2.0, I made a comment and temporary fix to support Ktor 2.0 until this library get revived.

#185

Cheers

Answer 9 · 2022-04-17T14:15:37.000Z

Hey @berserkore @ronjunevaldoz @NathanPB @joreilly and everyone else.
I had already raised a PR #179 for fixing this but I guess the owner is currently inactive now.
I have forked this library where the particular commit is there and I have tested it for very basic cases and was seem to be working. Didn't get much time before to properly maintain it but I think from now I can maintain it since I have a use for it in my personal project too. Would love to get feedback and will plan to actively maintain it soon.

Answer 10 · 2022-05-31T18:21:01.000Z

Hi all. Sorry for being inactive for such a long time.

I will start being active in this community again and I have now opened GitHub discussions and opened a discussion about getting more maintainers on this project (#187).

We want to keep this repository active and maintain the maven repository and the https://KGraphQL.io/ website.