aaemnnosttv/wp-cli-dotenv-command

Use locally generated salts whenever possible

swissspidy opened this issue · 1 comments

swissspidy commented

Just like in WordPress core and https://github.com/wp-cli/config-command, using the WordPress.org to get salts should be the last resort.

One should first try to generate them locally, for example with the help of random_int().

Here's the relevant WP-CLI code:

https://github.com/wp-cli/config-command/blob/9e3ccb8f013a7332c16a78ac68f9deee171b022f/src/Config_Command.php#L625-L682

aaemnnosttv commented

Hi Pascal, thanks for the suggestion. I'll add this change in the future 👍

  • 👍1