Remove references to deprecated v1 Android embedding

Question

Remove references to deprecated v1 Android embedding

Opened this issue 4 months ago · 5 comments

To ensure this plugin will work with users running the next stable version of Flutter remove references to the v1 embedding.

The v1 embedding was deprecated around 6 and a half years ago. In Flutter 3.22, the Flutter tool dropped support for building v1 apps entirely. Flutter plans to delete version one of it's Android embedding in the next stable release, per https://medium.com/flutter/whats-new-in-flutter-3-22-fbde6c164fe3 (in the "Removal of v1 Android embedding" section).

When that deletion happens, any apps using plugins that still have references to the removed classes will fail to build when updating to the next stable version (probably Flutter 3.26).

As a part of this deprecation, the Flutter Android team is doing community outreach by filing bugs and submitting some pull requests to update plugins to minimize the impact this removal has on the community.

Some example PRs:

Flutter team maintained plugins: flutter/packages#6494
android_alarm_manager_plus fluttercommunity/plus_plugins#2864

Consequences:

This change should have no impact on users of this plugin that are building apps using the v2 embedding (we don't have a percentage to share, but this is the vast majority of users).
It will remove support for users that are still using the v1 embedding on versions of Flutter older than 3.22.

If this change doesn't land, this plugin will instead be broken for all apps building on the next stable version of Flutter and beyond.

Is there a way to support both v1 and v2 embedding apps in the next stable version of Flutter?

No.

This is the PR where we are removing the deprecated engine classes: flutter/engine#52022

Answer 1 · 2024-10-09T09:23:04.000Z

@reidbaker This is a good issue, I'm surprised this project hasn't been maintained for so long. Are you working on it?

Answer 2 · 2024-10-17T14:49:14.000Z

I am not. I filed bugs against the top 1000 "most popular" plugins that had v1 embedding references. This is more than 50 plugins down my list so I likely wont ever get to it.

Answer 3 · 2024-10-17T14:50:59.000Z

Here are the references. The good news is they are only in the example app which means customers (aka plugin users) will likely not be affected.
Also it is probably a simple migration to import a different class.

Answer 4 · 2024-10-17T19:15:12.000Z

I think I'll work on it in my free time. Should be a simple migration indeed

Answer 5 · 2024-10-24T14:28:57.000Z

flutter/engine#52022 has been merged. Users targeting Flutter master and beta/stable releases after (but not including) 3.27 will fail to compile if the plugin has references any v1 embedding classes.

To aid in identifying these classes here is a search query you can run in github on your repo.

("io.flutter.view.FlutterMain" OR "io.flutter.view.FlutterNativeView" OR "io.flutter.view.FlutterView" OR "io.flutter.embedding.engine.plugins.shim" OR "io.flutter.app" OR "PluginRegistry.Registrar")