Recap: a lot of code is dead in assert() statements

[quiret]

Examples:
https://github.com/aap/librw/blob/master/src/image.cpp#L65
https://github.com/aap/librw/blob/master/src/image.cpp#L179
https://github.com/aap/librw/blob/master/src/image.cpp#L241
https://github.com/aap/librw/blob/master/src/geometry.cpp#L106

• it never finds the chunk if asserts are disabled

https://github.com/aap/librw/blob/master/src/image.cpp#L528

• it never opens the file for writing TGA if asserts are disabled

In Release mode, some compilers like to put the preprocessor definition "NDEBUG" to disable things like the "assert" macro to speed up code. In return, your code breaks because assert statements do not execute in Release mode anymore. Please take a look at this issue. :)

[JayFoxRox]

I've fixed these links for you. I believe all of those have been fixed

librw/src/image.cpp

Line 65 in 290117e

assert(findChunk(stream, ID_STRUCT, NULL, NULL));

librw/src/image.cpp

Line 179 in 290117e

assert(findChunk(stream, ID_STRUCT, NULL, NULL));

librw/src/image.cpp

Line 241 in 290117e

assert(findChunk(stream, ID_STRUCT, NULL, NULL));

librw/src/geometry.cpp

Line 106 in 290117e

assert(findChunk(stream, ID_STRUCT, NULL, &version));

(the one in writeTGA has been moved to tga.cpp since)

librw/src/image.cpp

Line 528 in 290117e

assert(file.open(filename, "wb"));

---

@aap this can be closed