aasharma90/UnprocessDenoising_PyTorch

A issue and correction method

Closed this issue · 4 comments

happycaoyue commented

bayer_pattern = np.asarray(np.array(info[info['camera'][0][i]]['pattern']).T).tolist()

aasharma90 commented

Hi @happycaoyue

Thanks for your suggestion. Is this correction intended for solving the white balance problem reported in the README file? If yes, could you please confirm by attaching a result? Also, please do open a pull request if that's the case so that I can merge it.

If not, could you please tell what is the issue for which this correction is?

happycaoyue commented

Yes, by this way, the discoloration problem (or the white balance problem) can be solved. The original code you write will get a wrong bayer_pattern, which is transpose matrix of correct bayer pattern.

aasharma90 commented

Hi @happycaoyue

Thanks for your feedback. It has fixed the problem, though if you could provide any rationale (or any documentation) on why the transpose is needed that would be highly appreciated.

aasharma90 commented

Hi, closing this as the issue has been resolved and there has been no further activity.