Incorrect error messages being passed to reject in GoogleLoginProvider.getAccessToken()
lwestfall opened this issue · 1 comments
lwestfall commented
The error messages in these logical branches should be swapped.
I can PR sometime this week, I'll so be refactoring all error messages as readonly strings a la SocialAuthService
.
angularx-social-login/projects/lib/src/providers/google-login-provider.ts
Lines 145 to 153 in 7f25ada
Heatmanofurioso commented
@lwestfall Thanks for the dedicated effort here.
I've been swamped with work, and haven't been able to do any PRs myself.
Looking forward to it if you can