abacritt/angularx-social-login

Incorrect error messages being passed to reject in GoogleLoginProvider.getAccessToken()

lwestfall opened this issue · 1 comments

The error messages in these logical branches should be swapped.

I can PR sometime this week, I'll so be refactoring all error messages as readonly strings a la SocialAuthService.

if (!this._tokenClient) {
if (this._socialUser.value) {
reject(
'No token client was instantiated, you should specify some scopes.'
);
} else {
reject('You should be logged-in first.');
}
} else {

@lwestfall Thanks for the dedicated effort here.
I've been swamped with work, and haven't been able to do any PRs myself.
Looking forward to it if you can