refactor zcl_abapgit_default_auth_info

Question

refactor zcl_abapgit_default_auth_info

larshp opened this issue 6 years ago · 4 comments

refactor zcl_abapgit_default_auth_info, it is part of core abapGit no need to have it implemented twice

Answer 1 · 2019-04-16T15:08:54.000Z

zcl_abapgit_default_auth_info is currently not part of core abapGit. Either we bring it to core or we enhance zcl_abapgit_login_manager.

Answer 2 · 2019-04-16T15:13:55.000Z

which enhancements are needed in zcl_abapgit_login_manager ?

Answer 3 · 2019-04-16T16:02:09.000Z

To avoid having several classes for credentials, it would be nice having one single class (zcl_abapgit_login_manager). It should "store" username/pw for a given repository as long as the session is alive.
The current implementation have a setter for username/pw. It would be perfect if it gets a getter method for username/pw as well.

Answer 4 · 2019-04-16T16:04:15.000Z

Then we can eliminate zcl_abagit_default_auth_info and use the login manager as substitude.