abarichello/godot-ci

No CI for the docker images themselves

neoq opened this issue · 2 comments

neoq commented

Hi, first of all, love the existing work.
I was just wondering how the images get to the docker hub. I assume @abarichello is pushing them manually at the moment because the github and gitlab CI only demonstrate the godot CI. If that is the case I suggest replacing the current CI by jobs that build the godot-ci images and automatically push and tag them on the docker hub for specific branches like master or 3.2. This would ensure that the images on the dockerhub are always in sync with the repository and it would make the image contents more transparent to the users. The godot-ci will still be demonstrated by the existing example repositories.

If desired, I could possibly submit a pull request implementing this as soon as I get to it.

Best regards

abarichello commented

I use Docker Hub's automated builds instead of building them myself. The latest tags are triggered manually to prevent new builds over commits that don't change the image itself while the other branches are built automatically.

image

For example, the current commit for the latest tag is 2c4434c since the commit 9213e16 only had README updates, you can actually see the dockercloud badge here:

image

I hope I made myself clear, let me know if you have any questions.

  • 👍1
neoq commented

Yeah that clears it up. Thank you. I did not think of Docker Hub's automated builds :)

  • 👍1