isssue with EquipmentandQuickSlots 2.0.0/.1
Nitrinax opened this issue · 14 comments
Mod: Crafting With Containers
Mod Version: 1.0.13
Describe the bug
The bug is that twice the amount of resources are used to build something.
So if something is built that requires 4 wood, then 8 are consumed. But when you destroy it, you only get 4 back. The same happens with stones.
How To Reproduce
Steps to reproduce the behavior:
- First do '...' equip the hammer, open the build menu and choose something, for example the Stakewall (it need 4 wood)
- Then do '....' build it
- After doing '....' look at your ressources
- Then this bug happens -> it consume 8 not 4
Additional details
the bug only appears if EquipmentandQuickSlots 2.0.0 / .1 installed, with the older version 1.0.5 it does not happen. i think there is an issue with variables that are overwritten or used by both mods
i also posted that issue on RandyKnapp/ValheimMods#66 for EquipmentandQuickSlots 2.0.0 / .1
Just encountered said bug where it completely disabled the mod when using EquipmentandQuickSlots 2.0.1. Had to revert back to 1.0.5 of the latter mod so that CraftingWithContainers can function again.
Thank you for the report! Indeed, I’ll look into the issue this weekend.
I don’t think the developer of EquipmentQuickslots had anything to do with this in a major way at this point, so please feel free to close RandyKnapp/ValheimMods#66 and let’s keep this issue as the main one for this problem.
I’ll open a ticket within that repo if the problem is something I really cannot workaround with a simple compatibility patch
Just encountered said bug where it completely disabled the mod when using EquipmentandQuickSlots 2.0.1. Had to revert back to 1.0.5 of the latter mod so that CraftingWithContainers can function again.
Me too friend, how did you do to revert?
forget it, I found the option after uninstalling and installing again using the r2modman. Thx anyway!
Just encountered said bug where it completely disabled the mod when using EquipmentandQuickSlots 2.0.1. Had to revert back to 1.0.5 of the latter mod so that CraftingWithContainers can function again.
Me too exactly.
I’ll open a ticket within that repo if the problem is something I really cannot workaround with a simple compatibility patch
The problem has only existed since the new 2.0.x versions of EquipmentQuickslots came out. Previously, with the 1.0.x versions of EquipmentQuickslots, they worked wonderfully together with CraftingWithContainers 1.0.13. So why should it only be CraftingWithContainers that has not received any update at all during this time?
Saw both issues.
Didn't draw from containers and was messing up build resources usage/refunding.
Just started with both latest versions of this mod and EquipmentQuickslots (2.0.2).
Looking into it. Counting works fine it seems, but removing items fails. From what I can see, recent versions of EquipmentQuickslots reroute all item removal calls on the player Inventory (as does CraftingWithContainers), hence we are running into a conflict here.
I can confirm that this incompatibility started with EquipmentandQuickslots, and the version of CraftingWithContainers does not change the outcome. I moved back to the older E&Q and CwC is back in business. Would it make sense for one to detect the other, and jump into the path of where the removal calls are going, based on whether or not the other mod is installed?
Fixed via a EQS detecting workaround in 1.0.14. Still needs a "proper" fix.
Sadly, I cannot work on the latter as I don't have the time to focus on it in the coming two weeks. CWC currently hooks inventory events completely like it used to in <=1.0.5, which I might need to reconsider and go for the less pretty (in my opinion) approach of completely detouring the crafting and building functions. For now, the workaround works, but it's quite ugly. Hopefully this keeps CwC stable for the time being.
That said, I do recommend people check out Crafting From Containers :) aedenthorn did a good job at it, while I was trying to be clever and got things ugly 😄 It's not available on the ThunderStore though (which I guess is also why CwC gets it's popularity).
This whole situation with there being two mods that pretty much do the same thing needs to come to an end at some point, and me not being able to properly support mod-compatibility for CwC might as well be just that trigger for it. This will mean that CwC will disappear from the ThunderStore and people will need to manually download Crafting From Containers from Nexus / use Vortex.
ThunderStore at this point also has very poor options for community interaction (none), so I don't even really know how many people use this, as downloads do not equal users, and any sort of discussion requires creating a GitHub account which many people do not feel like doing.
It would be nice to know what people using CwC think about the situation as CwC goes into hibernation mode. Also, if you are using CwC instead of Crafting From Containers, why? ThunderStore availability?
Update: I'm keeping this issue open for further reports on E&QS compatibility issues for now. There's also still a separate ticket for this on E&QS repo here: RandyKnapp/ValheimMods#62, but I would prefer if we kept these issues to this topic.
R2modman just feels easier to use at least for people who are not used to modding. I play mostly with friends and it was easier to have them download r2modman than Vortex as they are not really tech savvy. Along with the fact that I literally just have them install the mods I have from a file and they can play like that. I have used vortex but I feel like it would be too much for them whereas r2modman is just simplistic.
Thunderstore is actually all I know. If BepInEx would work with nexus, I’d use it. I just thought that was all there was, as I’ve not been back in modding stuff for a long while
…
On Mar 21, 2021, 5:56 PM -0400, abearcodes/Valheim @.***>, wrote: detouring
I think it works. But afaik, you have to install BepInEx manually as in copy the files into the game folders. Thunderstore is pretty much click and install BepInEx. Correct me if I am wrong. The only difference is the BepInEx installation. Everything else is done using Vortex software similar to r2modman.
Manually install BepInEx. Install Vortex. Install mods using Vortex. Run Valheim? Is that correct?
R2modman just feels easier to use at least for people who are not used to modding. I play mostly with friends and it was easier to have them download r2modman than Vortex as they are not really tech savvy. Along with the fact that I literally just have them install the mods I have from a file and they can play like that. I have used vortex but I feel like it would be too much for them whereas r2modman is just simplistic.
Could you clarify a bit the process to use Vortex with Valheim?
To be clear, I believe abearcodes is suggesting that people use aedenthorn's "Craft Build Smelt Cook Fuel Pull From Containers" from the Nexus (https://www.nexusmods.com/valheim/mods/40). It may have once been called "Crafting from Containers" but there is no mod that matches that name there any more.