Cache cleanup is unstable

[ximion]

When running the generate-metadata command and later running it again, without modifying the database inbetween, it is expected that no cache content gets removed, simply because no package is removed and therefore invalid cache entries should not exist.
However, I constantly get output like this:

[...]
('removed: ', '/srv/dak/export/metainfo/bartholomea/main/planner-235562/')
('removed: ', '/srv/dak/export/metainfo/bartholomea/main/scilab-cli-275198/')
('removed: ', '/srv/dak/export/metainfo/bartholomea/main/desktopnova-tray-22076/')
('removed: ', '/srv/dak/export/metainfo/bartholomea/main/ipython3-278132/')
('removed: ', '/srv/dak/export/metainfo/bartholomea/main/gnome-shell-timer-246808/')
('removed: ', '/srv/dak/export/metainfo/bartholomea/main/gnome-shell-pomodoro-273294/')
('removed: ', '/srv/dak/export/metainfo/bartholomea/main/terminatorx-197917/')
('removed: ', '/srv/dak/export/metainfo/bartholomea/main/spyder3-273662/')
('removed: ', '/srv/dak/export/metainfo/bartholomea/main/gcompris-277414/')
('removed: ', '/srv/dak/export/metainfo/bartholomea/main/gconf-cleaner-15996/')
('removed: ', '/srv/dak/export/metainfo/bartholomea/main/gconf-editor-108239/')
('removed: ', '/srv/dak/export/metainfo/bartholomea/main/sweethome3d-textures-editor-156704/')
('removed: ', '/srv/dak/export/metainfo/bartholomea/main/sweethome3d-furniture-editor-241419/')
cache cleared.

after running the metadata command the second time.
This indicates that the initial data was wrong, or that there is an issue with the cache cleanup.

[abhi11]

I have observed this too. Must be something wrong in the cleanup logic I'll fix it tomorrow.

[ximion]

Fixed in the recent commit - was actually a three-fold issue. Cache cleanup should now be rock-solid :-)