abhi1693/setup-browser

Action not working for Firefox latest

Closed this issue · 6 comments

kriegaex commented 
Run abhi1693/setup-browser@v0.1.1
  with:
    browser: firefox
    version: latest
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Adopt_jdk/8.0.92-1/x64

Error: File not found: '/home/runner/work/_actions/abhi169/setup-browser/v0.1.1/index.js'
abhi1693 commented

@kriegaex Thank you for reporting the issue. I have added the following versions for firefox

  • latest
  • latest-devedition
  • latest-beta
  • latest-esr
kriegaex commented

This does not seem to work either on Windows.

Run abhi1693/setup-browser@v0.3.0
  with:
    browser: firefox
    version: latest
  env:
    JAVA_HOME: C:\hostedtoolcache\windows\Java_Adopt_jdk\8.0.32-6\x64

Error: File not found: 'D:\a\_actions\abhi169\setup-browser\v0.3.0\index.js'

Did you test this? Maybe you shouldnot close issues so quickly without user feedback.

abhi1693 commented

@kriegaex Github closed the issue on its own when I merged the PR for Firefox on Linux.

Use v0.3.1, there was a binary path issue for windows with Firefox in the previous version.

You can check the build status at https://github.com/abhi1693/setup-browser/runs/5277424654?check_suite_focus=true

kriegaex commented

So what am I doing wrong?

build error screenshot

abhi1693 commented

@kriegaex I think the issue was caused by the missing dist directory. I have pushed it again to Github. Can you try now? If that does not work, can you try with main?

kriegaex commented

From https://github.com/kriegaex/GebSpockSamples/actions/runs/1878940472:

Run abhi1693/setup-browser@main
  with:
    browser: firefox
    version: latest
  env:
    JAVA_HOME: C:\hostedtoolcache\windows\Java_Adopt_jdk\8.0.32-6\x64

Error: File not found: 'D:\a\_actions\abhi169\setup-browser\main\index.js'

What I do not understand is: Why do your own tests not cover that? Why are you burning version numbers and using me as your guinea pig instead of testing this yourself? Trial & error is not a good strategy for software development, if there are good and obvious alternatives like in this case.

Looking at your own build workflow, does maybe this Yarn thingy make a difference? My own workflow is not using it.