Provide Continuous Integration Build Status
erayerdin opened this issue · 8 comments
I think it is better to provide a continuous integration build status just to inform the community about if build/tests pass or not.
TravisCI is a common CI tool for open-source project. If you allow, I can provide PR about this. You might need to create a Travis account though.
You're right, CI would be great. I would appreciate a PR since I have no clue on where to get started with setting it up.
If it requires a Travis account, it might be better for me to set it up. Do you think you can still make a PR?
The steps you need to do is:
- Create a Travis account (better with Github login).
- Add this project to Travis.
Then Travis will complain about that it couldn't find a proper configuration and will fail.
Then, inform me. Then I will fork the repository. Travis will also automatically check my repository. I will send pull-request to you. It will check PR again. Then you will merge. That's the plan. :)
I'm a bit busy right now, so I will @ you when I do it. Thank you so much!
No probs here. :) It can wait.
By the way, it doesn't seem like you have to create an account first. It seems like I can do whatever I can do with Travis without you creating one.
There is one issue, though, and it is that aiohttp dependency supports Python 3.4 with versions up to 2.3.10 but you have provided usage about Python 3.5 below versions on readme. You can see it here.
This does not mean it does not work with Python 3.4, maybe you have tested it by hand.
I execute tests starting from Python 3.5, hoping that it will not be an issue. It shouldn't be an issue since Python has a better stance about async and typing system starting from Python 3.5.
I'm going to remove Python 3.4 from the README.
Closing since #20 has been merged.