abhisharma404/vault

Refactor vault.py

mzfr opened this issue · 2 comments

mzfr commented

Currently, we have around 1200 lines of code in a single file which is probably not a good practice. Also, this will increase since we are going to continue to add more functions. So it would be good if we can move the functions out of the vault.py file and only keep it as an entry point and maybe perform basic checks on ip/url.

To call other functions we can have maybe a util directory where we can keep all the existing functions. This will increase the number of imports or number of files but it will definitely help us to keep everything clean in vault.py

abhisharma404 commented

@mzfr I was thinking about the same issue. I think it is a great idea, it will also be more easier to configure Travis later on.

raajtilaksarma commented

Hi, found this in KWOC. Would like to try to refactor it. But need some context on how to group functions (like which functions can be grouped into a module and then be imported into vault.py.