abo-abo/swiper

`counsel-tmm` needs updating for emacs 28

zabe40 opened this issue · 1 comments

The function tmm-get-keybind was removed in emacs 28 (specifically this commit), and counsel-tmm uses this function. Luckily, it looks like (menu-bar-keymap) is a drop-in replacement for (tmm-get-keybind [menu-bar]).

swiper/counsel.el

Line 4389 in 29b61fe

(counsel-tmm-prompt (tmm-get-keybind [menu-bar])))

Since I don't actually use counsel, this is an issue and not a pull request. I'm not sure how you handle compatability between different versions of emacs, but I wanted to let you know since I adapted counsel-tmm for my favored completion package (Selectrum), and it broke when I updated to 28.

Thanks for pinpointing the issue and its solution!
And sorry for the long delay in fixing this.