question for RequestExt.

Question

question for RequestExt.

kiuma opened this issue 7 years ago · 5 comments

Hello,
I was looking into your code and I've seen that RequestExt exports this method

fn into_multipart(self) -> Result<Self::Multipart, Self>;

I'm starting to use hyper and rust in general, but I immagined to use the api this way:

request.into_multipart().and_then( do_something }.then( write_response )

Am I missing something?
If this is the intended way of using the api, why this choice that seems little async way style ?

Kind regards,
Andrea

Answer 1 · 2017-11-09T06:45:34.000Z

i try to use this to, it seems the version published is not ready for this method, i suppose you use version 0.0.2, you can check the code https://docs.rs/crate/multipart-async/0.0.2/source/src/server/hyper.rs, it does't impl RequestExt for hyper Request.

but code in the master branch here seems has ready for hyper, any way, i try to use the code in the git ,and it work for this method

change the Cargo.toml like this

[dependencies.multipart-async]
version = "0.0"
git = "https://github.com/abonander/multipart-async.git"

Answer 2 · 2017-11-09T07:35:24.000Z

Thanks, it works. Il 09 nov 2017 7:45 AM, "Jiahao Huang" <notifications@github.com> ha scritto: i try to use this to, it seems the version published is not ready for this method, i suppose you use version 0.0.2, you can check the code https://docs.rs/crate/multipart-async/0.0.2/source/src/server/hyper.rs <http://here>, it does't impl RequestExt for hyper Request. but code in the master branch here seems has ready for hyper, any way, i try to use the code in the git ,and it work for this method change the Cargo.toml like this [dependencies.multipart-async] version = "0.0" git = "https://github.com/abonander/multipart-async.git" — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAkhii-zK3-6eHzrYvxcpqSG-kGQRIfTks5s0p-PgaJpZM4P-A4w> .

Answer 3 · 2017-11-09T08:47:54.000Z

well...i test on it, after get the Multipart, and call the wait method on it, it will hand hang for ever sometimes

Answer 4 · 2017-11-09T10:11:05.000Z

Ok I'll check it better. I'm writing my own hyper based web server.
As soon as I'll handle the multipart suff I'll share my repo with you to double check

Answer 5 · 2017-12-28T21:09:29.000Z

Sorry, I wasn't getting notifications for this repository for some reason. This crate isn't very well tested yet as it's still in development. For a while I was waiting on the Futures 0.2 refactor and then I got sidetracked with other projects as well as a new job. I'll probably be back to this in the coming weeks, though.