WrapAction does not respect hard wrap setting

Question

WrapAction does not respect hard wrap setting

mgartner opened this issue 3 years ago · 13 comments

Thanks for fixing #40!

As of version 1.6.0-SNAPSHOT, the WrapAction no longer respects the "Hard wrap at" setting. I'm not sure if the fix for #40 broke this, or if it was some other change.

Example

Both comment paragraphs had the WrapAction applied to them. The vertical line is at the 80-character hard wrap limit.

Settings

IDE version

Answer 1 · 2021-08-10T22:55:16.000Z

Interesting. @mgartner I couldn't reproduce.

However, can you check if you have a custom right margin override setting?

The plugin honors that override if it's present.

Answer 2 · 2021-08-10T22:57:49.000Z

I do have it set, but also at 80:

Answer 3 · 2021-08-10T23:11:02.000Z

The problem may specific to certain platforms.

I am using the plugin with PyCharm on two systems, one running Windows and the other running Pop!_OS (similar to Ubuntu). When I updated the plugin today on both systems, there were no problems on Pop!_OS, but on Windows, the wrapped text extended past column 80 (perhaps wrapping to column 100). I couldn't find any relevant difference in the PyCharm settings on the two system. In particular, both had the hard wrap set at 80.

On the Windows system, setting the right margin override to 80 didn't change the behavior. (Before today I have never tried the right margin override--instead I have just had the hard wrap set to 80.)

Answer 4 · 2021-08-10T23:34:57.000Z

Well, that's interesting. I'll try to reproduce on Windows!

Answer 5 · 2021-08-10T23:47:55.000Z

FWIW, I'm running macOS 11.5.

Answer 6 · 2021-08-11T03:47:31.000Z

👍 I was able to reproduce on a Mac and am looking at it now.

Answer 7 · 2021-08-11T11:40:48.000Z

I will say I also see this problem on my 11.5 Mac as well.

Answer 8 · 2021-08-11T21:01:10.000Z

Can confirm, after updating from 1.4 to to 1.6.0-SNAPSHOT, on macOS 11.4, the plugin no longer respects the "Right margin override" setting when wrapping JS comments that use the // operator. Wrapping does occur, but the margin setting is not respected.

For example, with a "Right margin override" of 80, I'm seeing lines up to 88 chars produced, after wrapping.

Answer 9 · 2021-08-12T08:53:10.000Z

Should be fixed in 1.7.0, now published to the Plugins Marketplace.

Answer 10 · 2021-08-12T14:42:34.000Z

The problem is resolved on my Windows system. Thank you so much! This plugin makes a huge difference in my daily work.

Answer 11 · 2021-08-12T15:52:14.000Z

Should be fixed in 1.7.0, now published to the Plugins Marketplace.

Looks good. Thank you, Andrew!

Answer 12 · 2021-08-12T16:31:02.000Z

Thanks @abrookins!!!

Answer 13 · 2021-08-12T18:31:37.000Z

Thanks @abrookins! I've been living in the dark ages these past few weeks.