abuiles/rails-csrf

Clarification on removing GET /api/csrf

Closed this issue · 9 comments

I'm a little confused by the current state of this add-on package due to 256842c. What was the rationale for the removal of the API call to fetch the CSRF token?

Furthermore, the docs mention that you must include a static CSRF token. Why is this? Seems like this would defeat the purpose of server generated CSRF tokens if you're able to pass arbitrary values to the server.

Thanks!

Just replied to you via email, if someone else wants to know the reason behind this please send me an email to builes.adolfo@gmail.com

Hey @abuiles can you elaborate on this publicly please?

@3v0k4 please send me an email

Hey @abuilies, sent you an email as well. awaiting your response.

Send you an email too

@krzkrzkrz FYI - I have not received a response from @abuiles yet.

I think it would make more sense to post some details here instead of asking ppl to send you a email to get details...

@jayswain It's not my line to give out the reason. The author did communicate it out to me though. It's not for me to say. I think it would be best to leave it to the author to decide if or how he should communicate the details. You can also try reaching him on irc/freenode server, #ember-cli channel.

Don't get me wrong. I do agree, some public details would be convenient for others.

I'm not longer maintaining this library, if someone wants to take over feel free to ping me 24fc8d2