abury/ABPadLockScreen

Support new iPhones screen ratio

marcoscurvello opened this issue · 6 comments

Is there a plan to support for the new iPhones screen size?

abury commented

Hey @marcoscurvello
What are the current issues? I've tested this on the iPhone 4, 5s, 6 & 6+ and it all seems to be working fine.
What issues are you experiencing?

I have probably found the bug @marcoscurvello is talking about. In case you have setted up a background view, on a new iPhones (iPhone 6 & iPhone 6 Plus) blurring view is applied, but not for the whole screen that is caused by this:

_contentView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, 320, MIN(frame.size.height, 568.0f))];

IMHO if you will decide to make contentView bigger it doesn't look as good as if it stays smaller.
So what I did is that I changed this

_backgroundBlurringView.frame = _contentView.frame;

to this:

_backgroundBlurringView.frame = self.frame;

This changes are made in ABPadLockScreenSetupView.m

See my Pull Request...

iPhone 6 Plus blurring bug

abury commented

Ah I see. That makes sense. Thanks for bringing it up!
I'll try and have a look at this in the next few days.

My pleasure.

Well tested and it works.

abury commented

This has been merged and can be closed.