acacode/swagger-typescript-api

Missing typings

Closed this issue · 9 comments

mividtim commented

The typings were removed from the dist dir and package.json in the 13.0.24 release. I use the library from TypeScript code in CI to verify that codegen will work with my changes when merging my API changes to main. I had to pin to 13.0.23, since 13.0.24 -> 13.0.28 (current release) have no typings. For a package with "typescript" in its name, I'm a little amazed...

grieblius commented

Hello - same issue - Could not find a declaration file for module 'swagger-typescript-api'.

smorimoto commented

Before raising an Issue, search for duplicates.

  • 👎1
mividtim commented

I did... I searched for "typings" and saw three unrelated issues. Can you link to the proper issue, so I can follow it, please?

grieblius commented

the issue is #1152 , however I see that issue is closed (solved?)
I installed v13.0.28, but still having this issue.

  • 👍1
mividtim commented

Looks like this PR wasn't included in the release that day...?

mividtim commented

Here's the PR where it was actually fixed. It was merged the same day as the 3.0.28 release, but I can't see a timestamp on the release to compare them.
#1149

smorimoto commented

So it's just not released yet.

  • 👍1
smorimoto commented

You can always thumbs down, but it should be kept in mind that maintainers always have other work to do, and everything is done by volunteers. You can always find the difference between the current latest release and main: 13.0.28...main

  • ❤️1
mividtim commented

I agree, but I also wasn't the one being glib, here. I definitely appreciate this package! And the maintainers. And we're all busy. Cheers.