acacode/swagger-typescript-api

Some descriptions failed to parse

Opened this issue · 4 comments

EinfachHans commented

Description

Today i tried updating from 13.2.8 -> 13.2.13.

I have the following problems:

1.

I have extractRequestParams set. I have one path param. Before my first parameter is:

myProp: string,

After it is:

 { myProp, ...query }: GetFormularParams,

2

Some descriptions failed to parse:

YAMLParseError: Missing closing "quote at line 45, column 85:
Happens for multiline descriptions like:

description: "Some context of line 1:\
        \ Some context of line 2"

This error doesn't occur before.

js2me commented

Hello @EinfachHans !

Can you share part of your swagger with this codegen result and input codegen params ?

EinfachHans commented

@js2me i created a quick repo:
https://github.com/EinfachHans/swagger-ts-api-bug

Steps to reproduce:

  1. Checkout & npm ci
  2. Update dependency to 13.2.13
  3. Run npm run generate
  4. See the changes about the parameters

I wasn't able to reproduce the multiline description bug, i will have a look why this happens for us, so let's focus on the first problem i described.

  • 👍1
smorimoto commented

1 was actually a "bug" in this tool. I will take a look at 2.

  • 👍1
EinfachHans commented

@smorimoto "was" a bug? It's not fixed yet, right? 😊