Make "Insert Image" Shortcut ⌘+Shift+G on Mac and Ctrl+Shift+G on Windows

Question

Make "Insert Image" Shortcut ⌘+Shift+G on Mac and Ctrl+Shift+G on Windows

Closed this issue 5 years ago · 7 comments

Make a "Insert Image" shortcut Ctrl+Shift+G on Windows and ⌘+Shift+G on Mac. Also change the tooltip of the "Insert Image" button to show the shortcut.

Answer 1 · 2020-04-12T19:36:51.000Z

I think this is being tracked in #296

Answer 2 · 2020-04-12T19:40:04.000Z

I think this is being tracked in #296

Isn't #296 to add shortcut support for hyperlinks only?

Answer 3 · 2020-04-12T19:42:40.000Z

Oof, yes, I'm on a roll today of not being able to read correctly.

Answer 4 · 2020-04-12T19:51:32.000Z

Thanks! Please assign this to me. Also, does mod+shift+G hotkey for inserting images sound good?

Answer 5 · 2020-04-12T20:08:22.000Z

@Michael-Grover thoughts?

Answer 6 · 2020-04-13T15:31:37.000Z

Google Docs, Microsoft Word, and github don't use shortcuts for inserting images, so it appears that it's not common to use a shortcut for this, but I guess it wouldn't hurt. Is there any precedent for mod+shift+G being the shortcut for adding images? Is the shortcut used for anything else by Windows, Mac, Chrome, Firefox, etc. that might cause issues?

Answer 7 · 2020-04-13T15:54:55.000Z

Google Docs, Microsoft Word, and github don't use shortcuts for inserting images, so it appears that it's not common to use a shortcut for this, but I guess it wouldn't hurt. Is there any precedent for mod+shift+G being the shortcut for adding images? Is the shortcut used for anything else by Windows, Mac, Chrome, Firefox, etc. that might cause issues?

MS Word (offline) uses Alt+N+P for inserting images but Stackedit is a popular online markdown editor that uses Ctrl+Shift+G, it also aligns well with the pattern of shortcuts we currently have. It doesn't look like this shortcut is being used by anything else, I tried it on Chrome and Firefox. Will send in a PR for this shortly.