accordproject/markdown-transform

Refactor the transfomer(OOXML<->CiceroMark)

K-Kumar-01 opened this issue · 0 comments

Discussion 🗣

Currently, the transformer for converting OOXML<->CiceroMark is quite big. The issue aims at dealing with refactoring it to reduce the size keeping the logic intact.

Context

Things to look at while refactoring:

  • More suitable naming for variables or functions
  • traverseNodes(): merge the 4th argument-parent properties into the properties argument and necessary changes in code for proper functioning. The reason being parent properties are generally used by nodes so they should be present in the properties itself.
  • generateTextOrCodeOOXML(): merge the 4th argument-parent properties into the properties argument and necessary changes in code for proper functioning. Same reason as above.
  • The tests currently for markdown-docx in algo-ooxml branch are uglified. Prettify all the tests.

Any other thing that can be refactored.

Detailed Description

The need for this issue arose during PR #441. Due to lack of time, the current implementation was done to launch a working transformer.