achorein/expo-share-intent

[Android] Warning causes by namespace "${group}" since 2.x.x version

Closed this issue · 3 comments

Describe the bug
A warning appears on pod install since 2.x.x version
warn Invalid application's package name "${group}" in either 'AndroidManifest.xml' or 'build.gradle'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id

It seems to be caused by:

android {
  def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION

  namespace "${group}"
  defaultConfig {
    versionCode 1
    versionName "${version}"
  }
}

in build.gradle

I don't know why I see this during pod install btw.

  • expo version (ex: 49) : 51
  • package version (ex: 1.2.0) : 2.0.1
  • platform target : Android / iOS

@TomCorvus i cannot reproduce with android studio jellyfish (Android 14 SDK 34, expo 51.0.17), is the problem persisting ?

@achorein Yes
Add "expo-share-intent": "^2.1.1" in basic example and type pod install in ios folder.
Capture d’écran 2024-07-10 à 09 18 57

This message seems to not appear if expo-share-intent is called from the source folder. (./src/*) You need to get it as a node module.

fixed in v2.3.0