Does not default exclude root node_modules in monorepo projects
erayhanoglu opened this issue · 1 comments
erayhanoglu commented
Hi. Thank you for this great tool. It helps us so much.
dpdm ignores node_modules by default. however in monorepo project it does not ignore root node_modules
$ dpdm src/** -T --exit-code circular:1 --tree false --warning false
✔ [11/11] Analyze done!
• Circular Dependencies
✅ Congratulations, no circular dependency were found in your project.
• Warnings
1) skip "../../node_modules/@nestjs/common/index.js", issuers: "src/storage-core.module.ts", "src/storage.decorators.ts" (1 more...)
2) skip "../../node_modules/minio/dist/main/minio.js", issuers: "src/providers/s3-storage-connection.ts"
acrazing commented
Could you check the version of your dpdm
? It's fine in my world (with version 3.8.0
):
➜ react git:(main) dpdm 'src/**' -T --exit-code circular:1 --tree false --warning false
✔ [9/9] Analyze done!
• Circular Dependencies
✅ Congratulations, no circular dependency were found in your project.
➜ react git:(main) dpdm 'src/**' -T --exit-code circular:1 --tree false --warning true
✔ [9/9] Analyze done!
• Circular Dependencies
✅ Congratulations, no circular dependency were found in your project.
• Warnings
1) miss "ninja" in "src/context.spec.tsx"
2) miss "ninja" in "src/useSelector.spec.tsx"
3) miss "ninja-testing" in "src/connect.spec.tsx"
4) miss "ninja-testing" in "src/useSelector.spec.tsx"
5) skip "../../node_modules/@testing-library/react-hooks/lib/index.js", issuers: "src/useSelector.spec.tsx"
6) skip "../../node_modules/@testing-library/react/dist/@testing-library/react.esm.js", issuers: "src/context.spec.tsx"
7) skip "../../node_modules/react/index.js", issuers: "src/connect.spec.tsx", "src/connect.tsx" (4 more...)
8) skip "../../node_modules/tslib/tslib.es6.js", issuers: "../core/dist/amos-core.esm.js", "../utils/dist/amos-utils.esm.js"
➜ react git:(main) dpdm --version
3.8.0
➜ react git:(main)