acryldata/datahub-helm

Kafka deployment does not work when enabling kraft

janfrederickk opened this issue · 5 comments

janfrederickk commented

Describe the bug
The installation of the helm chart does not work when using helm-drift detection.

When using flux v2 and the helm drift detection the helm controller does helm dry run against the cluster. An the used kafka helm chart has an error that, when enabling kraft two env variables will be created. This is fixed in kafka helm chart version 22.1.6

To Reproduce

Steps to reproduce the behavior:

  1. use fluxv2 and enable helm drift detection
  2. install prerequisites helm chart
  3. See the following error
failed to diff release against cluster resources: StatefulSet/datahub/prerequisites-kafka dry-run failed: 
failed to create manager for existing fields: 
failed to convert new object (datahub/prerequisites-kafka; apps/v1, Kind=StatefulSet) 
to smd typed: .spec.template.spec.containers[name="kafka"].env: duplicate entries for key [name="KAFKA_ENABLE_KRAFT"]

Additional context

fixed here kafka helm chart

pedro93 commented

Hello @jan-wacker

To be clear is the fix here to bump our kafka helm chart dependency from 22.1.3 to 22.1.6?

jan-wacker commented

@pedro93
Yes I haven't tested if there are breaking changes in Kafka causing DataHub to break.

jan-wacker commented

Hi @pedro93

I checked the kafka helm chart releases and these changes were made

bitnami/charts@45b550b
bitnami/charts@8d8d074
bitnami/charts@ec08951

It looks good to me please take a look :)

pedro93 commented

Looks good to me as well. Feel free to raise a PR for the version bump

pedro93 commented

Thank you for opening the ticket and making the fix! Closing issue as the PR has been merged.

  • 👍1