acryldata/datahub-helm

command in datahub-ingestion-cron values.yaml is incorrect

jimsmith opened this issue · 5 comments

This command is incorrect

#command: ["/bin/sh", "-c", "datahub ingest -c <recipe.fileName>"]

This error occurs:

client.go:142: [debug] creating 1 resource(s)
Error: INSTALLATION FAILED: 1 error occurred:
        * CronJob in version "v1" cannot be handled as a CronJob: json: cannot unmarshal array into Go struct field Container.spec.jobTemplate.spec.template.spec.containers.command of type string
        * 

The command is already duplicated:
["/bin/sh", "-c", is already in the helm template:

command: ["/bin/sh", "-c", {{ default $defaultCommand .command }} ]

This caused a few problems tracking this down, however it is a simple misconfiguration in values.yaml
command: "datahub ingest -c <recipe.fileName>"

After that it deploys into cluster as expected.

@jimsmith Thanks for reporting and figuring out the issue. I have raised a PR for fixing the issue.

@sachinsaju I looked at the PR and noticed you have the square brackets they did not work for me in the workaround

@jimsmith I have updated the PR.

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

Issue closed as I can see this has been merged #391